From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org, anayrey@gmail.com
Subject: Re: [libnftnl PATCH 2/3] tests: add tests for the masq expression
Date: Fri, 3 Oct 2014 14:08:19 +0200 [thread overview]
Message-ID: <20141003120819.GB10433@salvia> (raw)
In-Reply-To: <20141002115842.10972.64243.stgit@nfdev.cica.es>
On Thu, Oct 02, 2014 at 01:58:42PM +0200, Arturo Borrero Gonzalez wrote:
> The masq expression is lacking of tests. Let's add some.
Applied, thanks.
Please, make sure git am doesn't complain with trailing whitespace and
empty lines at the end of the file.
git am reported two in this patch.
> diff --git a/tests/jsonfiles/68-rule-masq.json b/tests/jsonfiles/68-rule-masq.json
> new file mode 100644
> index 0000000..cfaed4c
> --- /dev/null
> +++ b/tests/jsonfiles/68-rule-masq.json
> @@ -0,0 +1,2 @@
> +{"nftables":[{"rule":{"family":"ip6","table":"nat","chain":"postrouting","handle":4,"expr":[{"type":"masq","flags":12}]}}]}
> +
Here.
> +++ b/tests/xmlfiles/79-rule-masq.xml
^^
BTW, I wonder when the file numbering diverted (in xml, this 79 but in
json this is 68), it seems we have more tests for XML than json.
For similar mirror tests, we should be using the same number.
next prev parent reply other threads:[~2014-10-03 12:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 11:58 [libnftnl PATCH 1/3] expr: masq: optional printing of flags attr in snprintf_default Arturo Borrero Gonzalez
2014-10-02 11:58 ` [libnftnl PATCH 2/3] tests: add tests for the masq expression Arturo Borrero Gonzalez
2014-10-03 12:08 ` Pablo Neira Ayuso [this message]
2014-10-02 11:58 ` [libnftnl PATCH 3/3] tests: also test nat's flags attribute Arturo Borrero Gonzalez
2014-10-03 12:08 ` Pablo Neira Ayuso
2014-10-03 12:05 ` [libnftnl PATCH 1/3] expr: masq: optional printing of flags attr in snprintf_default Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141003120819.GB10433@salvia \
--to=pablo@netfilter.org \
--cc=anayrey@gmail.com \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).