netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: pablo@netfilter.org, alvaroneay@gmail.com
Subject: [libnftnl PATCH] src: cleanup in mxml and jansson regarding set_id parsing
Date: Fri, 10 Oct 2014 21:43:44 +0200	[thread overview]
Message-ID: <20141010194344.31948.59069.stgit@nfdev.cica.es> (raw)

jansson.c: In function 'nft_jansson_expr_parse':
jansson.c:212:6: warning: pointer targets in passing argument 3 of 'nft_set_lookup_id' differ in signedness [-Wpointer-sign]
In file included from jansson.c:10:0:
./internal.h:95:5: note: expected 'uint32_t *' but argument is of type 'int *'
jansson.c:195:18: warning: unused variable 'set_cur' [-Wunused-variable]
mxml.c: In function 'nft_mxml_expr_parse':
mxml.c:97:6: warning: pointer targets in passing argument 3 of 'nft_set_lookup_id' differ in signedness [-Wpointer-sign]
In file included from mxml.c:12:0:
internal.h:95:5: note: expected 'uint32_t *' but argument is of type 'int *'
mxml.c:68:18: warning: unused variable 'set_cur' [-Wunused-variable]

Spotted with: gcc (Debian 4.7.2-5) 4.7.2

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
 src/jansson.c |    4 ++--
 src/mxml.c    |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/jansson.c b/src/jansson.c
index 728de12..4c7968a 100644
--- a/src/jansson.c
+++ b/src/jansson.c
@@ -192,8 +192,8 @@ struct nft_rule_expr *nft_jansson_expr_parse(json_t *root,
 {
 	struct nft_rule_expr *e;
 	const char *type;
-	struct nft_set *set_cur = NULL;
-	int ret, set_id;
+	uint32_t set_id;
+	int ret;
 
 	type = nft_jansson_parse_str(root, "type", err);
 	if (type == NULL)
diff --git a/src/mxml.c b/src/mxml.c
index 22d482f..a97d380 100644
--- a/src/mxml.c
+++ b/src/mxml.c
@@ -65,8 +65,8 @@ struct nft_rule_expr *nft_mxml_expr_parse(mxml_node_t *node,
 	struct nft_rule_expr *e;
 	const char *expr_name;
 	char *xml_text;
-	struct nft_set *set_cur = NULL;
-	int ret, set_id;
+	uint32_t set_id;
+	int ret;
 
 	expr_name = mxmlElementGetAttr(node, "type");
 	if (expr_name == NULL) {


             reply	other threads:[~2014-10-10 19:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10 19:43 Arturo Borrero Gonzalez [this message]
2014-10-11 10:27 ` [libnftnl PATCH] src: cleanup in mxml and jansson regarding set_id parsing Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141010194344.31948.59069.stgit@nfdev.cica.es \
    --to=arturo.borrero.glez@gmail.com \
    --cc=alvaroneay@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).