[PATCH] libipset: Add missing ipset_parse_uint16 to map file

[PATCH] libipset: Add missing ipset_parse_uint16 to map file

[Neutron Soutmun]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

The libipset was not included the ipset_parse_uint16 symbol

Signed-off-by: Neutron Soutmun <neo.neutron@gmail.com>
---
 lib/libipset.map | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/libipset.map b/lib/libipset.map
index 58174ec..74069dc 100644
--- a/lib/libipset.map
+++ b/lib/libipset.map
@@ -149,6 +149,7 @@ LIBIPSET_4.3 {
 global:
   ipset_parse_skbmark;
   ipset_parse_skbprio;
+  ipset_parse_uint16;
   ipset_print_skbmark;
   ipset_print_skbprio;
 } LIBIPSET_4.2;
-- 
2.1.1


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] libipset: Add missing ipset_parse_uint16 to map file

[Jozsef Kadlecsik]

On Fri, 17 Oct 2014, Neutron Soutmun wrote:

> The libipset was not included the ipset_parse_uint16 symbol
> 
> Signed-off-by: Neutron Soutmun <neo.neutron@gmail.com>
> ---
>  lib/libipset.map | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/libipset.map b/lib/libipset.map
> index 58174ec..74069dc 100644
> --- a/lib/libipset.map
> +++ b/lib/libipset.map
> @@ -149,6 +149,7 @@ LIBIPSET_4.3 {
>  global:
>    ipset_parse_skbmark;
>    ipset_parse_skbprio;
> +  ipset_parse_uint16;
>    ipset_print_skbmark;
>    ipset_print_skbprio;
>  } LIBIPSET_4.2;

Yes, that's missing from the map file. However, please advance the API 
curr and age in Make_global.am and add a new section to libipset.map 
instead of inserting the symbol as above. Better not change the library 
silently...

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary

Re: [PATCH] libipset: Add missing ipset_parse_uint16 to map file

[Neutron Soutmun]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

On Wed, Oct 22, 2014 at 09:44:45PM +0200, Jozsef Kadlecsik wrote:
> On Fri, 17 Oct 2014, Neutron Soutmun wrote:
> Yes, that's missing from the map file. However, please advance the API 
> curr and age in Make_global.am and add a new section to libipset.map 
> instead of inserting the symbol as above. Better not change the library 
> silently...

The new proposed patch is posted at
http://marc.info/?l=netfilter-devel&m=141414339032035&w=2

Please review again.

Best regards,
Neutron Soutmun

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]