From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH v3] utils: fix arp family number
Date: Tue, 21 Oct 2014 09:59:27 +0200 [thread overview]
Message-ID: <20141021075927.GA3610@salvia> (raw)
In-Reply-To: <20141020115049.27980.35459.stgit@nfdev.cica.es>
On Mon, Oct 20, 2014 at 01:52:18PM +0200, Arturo Borrero Gonzalez wrote:
> NFPROTO_ARP = 3 in kernel space.
>
> We need the same value here in userspace in order to correctly communicate
> with the kernel.
>
> The failure solved by this patch made that {XML|JSON}-parsed tables of ARP
> family unable to be directly injected into kernel.
>
> To prevent future errors, this patch changes raw and AF_* values by the mathing
> NFPROTO_* couterpart as seen in linux/netfilter.h in both functions:
> * nft_family2str()
> * nft_str2family()
Applied, thanks.
BTW, it would be good to see a similar refactor in nft_verdict2str().
next prev parent reply other threads:[~2014-10-21 7:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 11:52 [libnftnl PATCH v3] utils: fix arp family number Arturo Borrero Gonzalez
2014-10-21 7:59 ` Pablo Neira Ayuso [this message]
2014-10-21 8:53 ` Arturo Borrero Gonzalez
2014-10-21 9:56 ` Pablo Neira Ayuso
2014-10-21 9:57 ` Pablo Neira Ayuso
2014-10-22 14:24 ` Arturo Borrero Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021075927.GA3610@salvia \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).