From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: bridge: Do not compile options in br_parse_ip_options Date: Fri, 24 Oct 2014 14:28:06 +0200 Message-ID: <20141024122806.GA4571@salvia> References: <1412384670-17794-1-git-send-email-fw@strlen.de> <20141004035606.GA8228@gondor.apana.org.au> <20141004100413.GA1241@breakpoint.cc> <20141004135508.GA10705@gondor.apana.org.au> <20141004141802.GA10878@gondor.apana.org.au> <20141024104149.GA7401@breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Herbert Xu , netfilter-devel@vger.kernel.org, bsd@redhat.com, stephen@networkplumber.org, netdev@vger.kernel.org, eric.dumazet@gmail.com, davidn@davidnewall.com, "David S. Miller" To: Florian Westphal Return-path: Received: from mail.us.es ([193.147.175.20]:40273 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756140AbaJXM0g (ORCPT ); Fri, 24 Oct 2014 08:26:36 -0400 Content-Disposition: inline In-Reply-To: <20141024104149.GA7401@breakpoint.cc> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Fri, Oct 24, 2014 at 12:41:49PM +0200, Florian Westphal wrote: > Herbert Xu wrote: > > bridge: Do not compile options in br_parse_ip_options > > > > Commit 462fb2af9788a82a534f8184abfde31574e1cfa0 > > > > bridge : Sanitize skb before it enters the IP stack > > > > broke when IP options are actually used because it mangles the > > skb as if it entered the IP stack which is wrong because the > > bridge is supposed to operate below the IP stack. > > > > Since nobody has actually requested for parsing of IP options > > this patch fixes it by simply reverting to the previous approach > > of ignoring all IP options, i.e., zeroing the IPCB. > > > > If and when somebody who uses IP options and actually needs them > > to be parsed by the bridge complains then we can revisit this. > > > > Reported-by: David Newall > > Signed-off-by: Herbert Xu > > Tested-by: Florian Westphal Applied, thanks a lot for testing Florian.