From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/3] netfilter: nfnetlink_log: fix maximum packet length logged to userspace
Date: Fri, 24 Oct 2014 14:33:53 +0200 [thread overview]
Message-ID: <20141024123352.GB4587@salvia> (raw)
In-Reply-To: <1414053368-29037-3-git-send-email-fw@strlen.de>
On Thu, Oct 23, 2014 at 10:36:07AM +0200, Florian Westphal wrote:
> don't try to queue payloads > 0xffff - NLA_HDRLEN, it does not work.
> The nla length includes the size of the nla struct, so anything larger
> results in u16 integer overflow.
>
> This patch is similar to
> 9cefbbc9c8f9abe (netfilter: nfnetlink_queue: cleanup copy_range usage).
Indeed, if we find problem in nfqueue, we should also keep in mind
that we should revisit nflog too. Those two codebases are very similar
(I suspect one forked from another at some point, with ad-hoc
modifications to each case).
Applied, thanks a lot for taking the time to look into this.
next prev parent reply other threads:[~2014-10-24 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 8:36 [PATCH 0/3] netfilter: nf_log: nlmsg size fixes Florian Westphal
2014-10-23 8:36 ` [PATCH 1/3] netfilter: nf_log: account for size of NLMSG_DONE attribute Florian Westphal
2014-10-24 12:30 ` Pablo Neira Ayuso
2014-10-24 12:39 ` Pablo Neira Ayuso
2014-10-23 8:36 ` [PATCH 2/3] netfilter: nfnetlink_log: fix maximum packet length logged to userspace Florian Westphal
2014-10-24 12:33 ` Pablo Neira Ayuso [this message]
2014-10-23 8:36 ` [PATCH 3/3] netfilter: nf_log: release skbuff on nlmsg put failure Florian Westphal
2014-10-24 12:35 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024123352.GB4587@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).