From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Marcelo Ricardo Leitner <mleitner@redhat.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] netfilter: log: protect nf_log_register against double registering
Date: Thu, 30 Oct 2014 17:31:39 +0100 [thread overview]
Message-ID: <20141030163139.GC2270@salvia> (raw)
In-Reply-To: <7be00bf663b212d4984414346da216cf17d3443d.1414586968.git.mleitner@redhat.com>
On Wed, Oct 29, 2014 at 10:51:13AM -0200, Marcelo Ricardo Leitner wrote:
> Currently, despite the comment right before the function,
> nf_log_register allows registering two loggers on with the same type and
> end up overwriting the previous register.
>
> Not a real issue today as current tree doesn't have two loggers for the
> same type but it's better to get this protected.
>
> Also make sure that all of its callers do error checking.
Also applied, thanks.
prev parent reply other threads:[~2014-10-30 16:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 12:51 [PATCH v4 1/3] netfilter: log: protect nf_log_register against double registering Marcelo Ricardo Leitner
2014-10-29 12:51 ` [PATCH v4 2/3] Do error handling if __build_packet_message fails Marcelo Ricardo Leitner
2014-11-04 16:47 ` Pablo Neira Ayuso
2014-11-04 18:01 ` Marcelo Ricardo Leitner
2014-11-04 18:26 ` Pablo Neira Ayuso
2014-11-04 18:52 ` Marcelo Ricardo Leitner
2014-11-04 19:04 ` Pablo Neira Ayuso
2014-11-04 19:08 ` Marcelo Ricardo Leitner
2014-11-04 19:11 ` Florian Westphal
2014-11-06 1:07 ` Pablo Neira Ayuso
2014-11-06 2:19 ` Florian Westphal
2014-10-29 12:51 ` [PATCH v4 3/3] Make use of pr_fmt where applicable Marcelo Ricardo Leitner
2014-11-04 16:50 ` Pablo Neira Ayuso
2014-11-04 17:11 ` Marcelo Ricardo Leitner
2014-10-30 16:31 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030163139.GC2270@salvia \
--to=pablo@netfilter.org \
--cc=mleitner@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).