From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [nft PATCH v2] src: add redirect support Date: Thu, 30 Oct 2014 17:33:29 +0100 Message-ID: <20141030163329.GA2298@salvia> References: <20141016104056.8678.71075.stgit@nfdev.cica.es> <20141030162520.GA2074@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: Arturo Borrero Gonzalez Return-path: Received: from mail.us.es ([193.147.175.20]:34585 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759800AbaJ3Qbu (ORCPT ); Thu, 30 Oct 2014 12:31:50 -0400 Content-Disposition: inline In-Reply-To: <20141030162520.GA2074@salvia> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Thu, Oct 30, 2014 at 05:25:20PM +0100, Pablo Neira Ayuso wrote: > On Thu, Oct 16, 2014 at 12:41:19PM +0200, Arturo Borrero Gonzalez wrote: > > This patch adds redirect support for nft. > > > > The syntax is: > > > > % nft add rule nat prerouting redirect [port|nat_flags] > > I prefer if you add a couple of valid examples to the patch > description. This won't work as the protocol is not specified. > > There's also some minor issues with this patch: > > % nft add rule nat prerouting redirect > Memory allocation failure > > Please, address and resubmit, thanks Arturo. BTW, please integrate the .t test file for the automated regression testing in the next version of this patch.