From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Gao feng <gaofeng@cn.fujitsu.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: bridge: unshare bridge info before change it
Date: Tue, 4 Nov 2014 20:00:55 +0100 [thread overview]
Message-ID: <20141104190055.GA27683@salvia> (raw)
In-Reply-To: <54582195.20209@cn.fujitsu.com>
On Tue, Nov 04, 2014 at 08:45:09AM +0800, Gao feng wrote:
> On 09/29/2014 03:35 PM, Gao feng wrote:
> > Many packets may share the same bridge information,
> > we should unshare the bridge info before we change it,
> > otherwise other packets will go to PF_INET(6)/PRE_ROUTING
> > second time or the pkt_type of other packets will be
> > incorrect.
> >
> > The problem occurs when we do nfqueue after br_nf_pre_routing
> > and before bf_nf_pre_routing_finish, if the packet is gso,
> > the new segs will share the same bridge info. and netfilter
> > may use skb_clone, this will cause many packets share the
> > same bridge info too.
> >
> > Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
> > ---
>
> any comments?
This doesn't apply cleanly. We modularized br_netfilter by the time
you sent this, see 54dc125. You'll have to rebase this patch.
Moreover, could you develop what you're noticing a bit more? Thanks.
next prev parent reply other threads:[~2014-11-04 18:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 7:35 [PATCH] netfilter: bridge: unshare bridge info before change it Gao feng
2014-11-04 0:45 ` Gao feng
2014-11-04 19:00 ` Pablo Neira Ayuso [this message]
2014-11-05 2:01 ` Gao feng
2014-11-05 2:13 ` Gao feng
2014-11-13 14:13 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104190055.GA27683@salvia \
--to=pablo@netfilter.org \
--cc=gaofeng@cn.fujitsu.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).