From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: arturo.borrero.glez@gmail.com, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH -nf] nft: masq: fix uninitialized range in nft_masq_{ipv4,ipv6}_eval
Date: Mon, 10 Nov 2014 20:20:24 +0100 [thread overview]
Message-ID: <20141110192024.GA25464@salvia> (raw)
In-Reply-To: <1415370894-31528-1-git-send-email-dborkman@redhat.com>
On Fri, Nov 07, 2014 at 03:34:54PM +0100, Daniel Borkmann wrote:
> When transferring from the original range in nf_nat_masquerade_{ipv4,ipv6}()
> we copy over values from stack in from min_proto/max_proto due to uninitialized
> range variable in both, nft_masq_{ipv4,ipv6}_eval. As we only initialize
> flags at this time from nft_masq struct, just zero out the rest.
Applied, thanks Daniel!
prev parent reply other threads:[~2014-11-10 19:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 14:34 [PATCH -nf] nft: masq: fix uninitialized range in nft_masq_{ipv4,ipv6}_eval Daniel Borkmann
2014-11-10 19:20 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110192024.GA25464@salvia \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=dborkman@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).