From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org, giuseppelng@gmail.com
Subject: Re: [iptables PATCH] iptables/nft-shared.c: kill add_*() invflags parameter
Date: Tue, 11 Nov 2014 20:47:39 +0100 [thread overview]
Message-ID: <20141111194739.GA6293@salvia> (raw)
In-Reply-To: <20141111183028.5708.94480.stgit@nfdev.cica.es>
On Tue, Nov 11, 2014 at 07:30:28PM +0100, Arturo Borrero Gonzalez wrote:
> diff --git a/iptables/nft-shared.h b/iptables/nft-shared.h
> index 468da5c..4872226 100644
> --- a/iptables/nft-shared.h
> +++ b/iptables/nft-shared.h
> @@ -38,6 +38,12 @@
>
> struct xtables_args;
>
> +#define NFT_INVFLAGS2CMP(op, invflags, flag) \
> + if (invflags & flag) \
> + op = NFT_CMP_NEQ; \
> + else \
> + op = NFT_CMP_EQ; \
No macros please, use a function instead and place it in iptables/nft.c
prev parent reply other threads:[~2014-11-11 19:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 18:30 [iptables PATCH] iptables/nft-shared.c: kill add_*() invflags parameter Arturo Borrero Gonzalez
2014-11-11 19:47 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111194739.GA6293@salvia \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=giuseppelng@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).