[PATCH] arptables: remove dead dynamic hooks code

[PATCH] arptables: remove dead dynamic hooks code

[Gustavo Zacarias]

The code is unused and #if'ed away, it also breaks pure-static
builds because of the dlfcn.h include.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 arptables.c              |  1 -
 libarptc/libarptc_incl.c | 15 ---------------
 2 files changed, 16 deletions(-)

diff --git a/arptables.c b/arptables.c
index 64ac3aa..845e226 100644
--- a/arptables.c
+++ b/arptables.c
@@ -35,7 +35,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <inttypes.h>
-#include <dlfcn.h>
 #include <ctype.h>
 #include <stdarg.h>
 #include <limits.h>
diff --git a/libarptc/libarptc_incl.c b/libarptc/libarptc_incl.c
index 9c1aeac..1d2e8b7 100644
--- a/libarptc/libarptc_incl.c
+++ b/libarptc/libarptc_incl.c
@@ -257,22 +257,7 @@ TC_INIT(const char *tablename)
 	    == NULL)
 		return NULL;
 
-/* Too hard --RR */
-#if 0
-	sprintf(pathname, "%s/%s", ARPT_LIB_DIR, info.name);
-	dynlib = dlopen(pathname, RTLD_NOW);
-	if (!dynlib) {
-		errno = ENOENT;
-		return NULL;
-	}
-	h->hooknames = dlsym(dynlib, "hooknames");
-	if (!h->hooknames) {
-		errno = ENOENT;
-		return NULL;
-	}
-#else
 	h->hooknames = hooknames;
-#endif
 
 	/* Initialize current state */
 	h->info = info;
-- 
2.0.4

Re: [PATCH] arptables: remove dead dynamic hooks code

[Pablo Neira Ayuso]

On Tue, Nov 11, 2014 at 10:20:22AM -0300, Gustavo Zacarias wrote:
> The code is unused and #if'ed away, it also breaks pure-static
> builds because of the dlfcn.h include.

Applied, thanks.