Re: arm64 allmodconfig failures in nft_reject_bridge.c

Re: arm64 allmodconfig failures in nft_reject_bridge.c

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

Since about -rc3 we've been seeing build failures in Linus' tree on
arm64 allmodconfig due to:

> 	arm64-allmodconfig
> ../net/bridge/netfilter/nft_reject_bridge.c:240:3: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]

By the time I looked into this it was fixed in -next by c1207c049b204b0
(netfilter: nft_reject_bridge: Fix powerpc build error) from Guenter but
that doesn't seem to have made it into -rc4 so I just wanted to check
that this fix was intended to go to Linus before v3.18?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: arm64 allmodconfig failures in nft_reject_bridge.c

[Pablo Neira Ayuso]

On Thu, Nov 13, 2014 at 11:33:20AM +0000, Mark Brown wrote:
> Since about -rc3 we've been seeing build failures in Linus' tree on
> arm64 allmodconfig due to:
> 
> > 	arm64-allmodconfig
> > ../net/bridge/netfilter/nft_reject_bridge.c:240:3: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
> 
> By the time I looked into this it was fixed in -next by c1207c049b204b0
> (netfilter: nft_reject_bridge: Fix powerpc build error) from Guenter but
> that doesn't seem to have made it into -rc4 so I just wanted to check
> that this fix was intended to go to Linus before v3.18?

I can see this in David's tree:

http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=c1207c049b204b0a96535dc5416aee331b51e0e1

I think this was reported by when -rc4 was already out, so you'll see
this by -rc5.

Re: arm64 allmodconfig failures in nft_reject_bridge.c

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

On Thu, Nov 13, 2014 at 12:43:57PM +0100, Pablo Neira Ayuso wrote:

> I can see this in David's tree:

> http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=c1207c049b204b0a96535dc5416aee331b51e0e1

> I think this was reported by when -rc4 was already out, so you'll see
> this by -rc5.

The fix predates -rc4 (sent on the 2nd, committed on the 3rd, -rc4 was
on the 9th), I'd been expecting to see it turn up there or shortly
after.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: arm64 allmodconfig failures in nft_reject_bridge.c

[David Miller]

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Thu, 13 Nov 2014 12:43:57 +0100

> On Thu, Nov 13, 2014 at 11:33:20AM +0000, Mark Brown wrote:
>> Since about -rc3 we've been seeing build failures in Linus' tree on
>> arm64 allmodconfig due to:
>> 
>> > 	arm64-allmodconfig
>> > ../net/bridge/netfilter/nft_reject_bridge.c:240:3: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
>> 
>> By the time I looked into this it was fixed in -next by c1207c049b204b0
>> (netfilter: nft_reject_bridge: Fix powerpc build error) from Guenter but
>> that doesn't seem to have made it into -rc4 so I just wanted to check
>> that this fix was intended to go to Linus before v3.18?
> 
> I can see this in David's tree:
> 
> http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=c1207c049b204b0a96535dc5416aee331b51e0e1
> 
> I think this was reported by when -rc4 was already out, so you'll see
> this by -rc5.

I hold changes in my tree for a week or more, because I want them to
"cook" there before they go to Linus.

So if it takes a week or two for a bug fix like this to propagate into
Linus's tree, that's just what sometimes happens.

In the mean time you can apply the fix locally if you absolutely have
to have it right at this moment, that is the freedom that everyone
has.

FWIW, I plan to push my tree to Linus some time today, so this will be
resolved in the next day or so.

Thanks.

Re: arm64 allmodconfig failures in nft_reject_bridge.c

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

On Thu, Nov 13, 2014 at 02:35:13PM -0500, David Miller wrote:

> I hold changes in my tree for a week or more, because I want them to
> "cook" there before they go to Linus.

Hrm.  Guess there must've been some other change in -next that pulled
the header in implicitly here :(

> So if it takes a week or two for a bug fix like this to propagate into
> Linus's tree, that's just what sometimes happens.

> In the mean time you can apply the fix locally if you absolutely have
> to have it right at this moment, that is the freedom that everyone
> has.

This can be a bit problematic for build (or widespread boot) breaks in
common configs since it takes out all the automated runtime testing that
people have running for the time the build break is in place.  In this
case it was just allmodconfig so it doesn't really get non-build testing
and makes little difference but for defconfigs it can be a more
substantial impact.  Applying fixes locally doesn't really work for this
case.

> FWIW, I plan to push my tree to Linus some time today, so this will be
> resolved in the next day or so.

Great, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: arm64 allmodconfig failures in nft_reject_bridge.c

[David Miller]

From: Mark Brown <broonie@kernel.org>
Date: Thu, 13 Nov 2014 19:47:52 +0000

> On Thu, Nov 13, 2014 at 02:35:13PM -0500, David Miller wrote:
> 
>> I hold changes in my tree for a week or more, because I want them to
>> "cook" there before they go to Linus.
> 
> Hrm.  Guess there must've been some other change in -next that pulled
> the header in implicitly here :(

-next pulls in my 'net' tree, so got the fix.

Re: arm64 allmodconfig failures in nft_reject_bridge.c

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

On Thu, Nov 13, 2014 at 03:23:53PM -0500, David Miller wrote:
> Date: Thu, 13 Nov 2014 19:47:52 +0000

> > On Thu, Nov 13, 2014 at 02:35:13PM -0500, David Miller wrote:

> >> I hold changes in my tree for a week or more, because I want them to
> >> "cook" there before they go to Linus.

> > Hrm.  Guess there must've been some other change in -next that pulled
> > the header in implicitly here :(

> -next pulls in my 'net' tree, so got the fix.

Right, but we didn't see the problem before you sent the tree with the
problematic patch to Linus - we didn't detect it in -next.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]