From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, dborkman@redhat.com,
jp.pozzi@izzop.net, programme110@gmail.com, brouer@redhat.com
Subject: Re: [PATCH 1/2 nf] Revert "netfilter: conntrack: fix race in __nf_conntrack_confirm against get_next_corpse"
Date: Tue, 25 Nov 2014 13:26:29 +0100 [thread overview]
Message-ID: <20141125132629.28448018@redhat.com> (raw)
In-Reply-To: <1416870887-5285-1-git-send-email-pablo@netfilter.org>
On Tue, 25 Nov 2014 00:14:46 +0100
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> This reverts commit 5195c14c8b27cc0b18220ddbf0e5ad3328a04187.
>
> If the conntrack clashes with an existing one, it is left out of
> the unconfirmed, thus, crashing when dropping the packet and
> releasing the conntrack.
>
> Reported-by: Daniel Borkmann <dborkman@redhat.com>
> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=88841
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
> I prefer to revert the original fix and replace it by the follow up to
> pass one single patch to -stable.
I'm fine with the revert.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2014-11-25 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 23:14 [PATCH 1/2 nf] Revert "netfilter: conntrack: fix race in __nf_conntrack_confirm against get_next_corpse" Pablo Neira Ayuso
2014-11-24 23:14 ` [PATCH 2/2 nf] netfilter: conntrack: fix race between confirmation and flush Pablo Neira Ayuso
2014-11-25 20:29 ` Jesper Dangaard Brouer
2014-11-25 12:26 ` Jesper Dangaard Brouer [this message]
2014-11-25 18:59 ` [PATCH 1/2 nf] Revert "netfilter: conntrack: fix race in __nf_conntrack_confirm against get_next_corpse" Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125132629.28448018@redhat.com \
--to=brouer@redhat.com \
--cc=dborkman@redhat.com \
--cc=jp.pozzi@izzop.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=programme110@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).