Re: [nft-sync PATCH 2/3] mnl: sync source code with nft

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Fri, Dec 26, 2014 at 01:51:28PM +0100, Arturo Borrero Gonzalez wrote:
> Let's update the mnl source code to match the latest in nft.

Please, split this in smaller patches, it's good to keep track of the
git history when looking at the past.

> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
> ---
>  include/linux/netfilter/nf_tables.h |  125 +++++++++++++++++++++-
>  include/mnl.h                       |    2 
>  include/utils.h                     |    9 ++
>  src/main.c                          |    2 
>  src/mnl.c                           |  198 ++++++++++++++++++++++-------------
>  src/utils.c                         |    7 +
>  6 files changed, 261 insertions(+), 82 deletions(-)
> 
> diff --git a/include/linux/netfilter/nf_tables.h b/include/linux/netfilter/nf_tables.h
> index 11d5937..832bc46 100644
> --- a/include/linux/netfilter/nf_tables.h
> +++ b/include/linux/netfilter/nf_tables.h
[...]

At least this one should come in an initial patch to refresh the
cached header.

We should also start abstracting and moving things to the library in a
way that nft-sync can reuse, so we avoid code redundancy.