From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Asbjoern Sloth Toennesen <asbjorn@asbjorn.biz>
Cc: "David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] nftables: nft_flush_table: handle chain dependencies
Date: Mon, 5 Jan 2015 12:39:07 +0100 [thread overview]
Message-ID: <20150105113907.GA15161@salvia> (raw)
In-Reply-To: <1419640765-7707-1-git-send-email-asbjorn@asbjorn.biz>
On Sat, Dec 27, 2014 at 12:39:25AM +0000, Asbjoern Sloth Toennesen wrote:
> Update: I errously assumed that git add, while writing the commit
> message, would be added to the commit.
> Based on net-next f96fe225. Compiles and checkpatch clean.
>
> Jumping between chains doesn't mix well with flush ruleset,
> since nft_flush_table doesn't handle chains referencing chains.
>
> This way it will take one to two loops, to settle.
> Alternatively it can be solved by always having two loops,
I just sent you a different patch to address this, we may still have
references from the elements to chains when using dictionaries, so I
prefer to schedule the object release in this order:
rules -> sets -> chains -> tables
Thanks for diagnosing and sending an initial fix.
P.S: I hope you enjoyed 31c3.
prev parent reply other threads:[~2015-01-05 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-26 22:51 [PATCH] nftables: nft_flush_table: handle chain dependencies Asbjoern Sloth Toennesen
2014-12-27 0:39 ` [PATCH v2] " Asbjoern Sloth Toennesen
2015-01-05 11:39 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105113907.GA15161@salvia \
--to=pablo@netfilter.org \
--cc=asbjorn@asbjorn.biz \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).