From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org, giuseppelng@gmail.com
Subject: Re: [ebtables-compat PATCH v2] ebtables-compat: fix segfault in rules w/o target
Date: Tue, 6 Jan 2015 22:18:50 +0100 [thread overview]
Message-ID: <20150106211850.GA5942@salvia> (raw)
In-Reply-To: <20150105142519.26315.13246.stgit@nfdev.cica.es>
On Mon, Jan 05, 2015 at 03:28:46PM +0100, Arturo Borrero Gonzalez wrote:
> This patch fixes a segfault in rules without target.
>
> Now, these two rules are allowed:
>
> % ebtables-compat -A FORWARD -p 0x0600 -j CONTINUE
> % ebtables-compat -A FORWARD -p 0x0600
>
> And both are printed:
>
> Bridge chain: FORWARD, entries: 1, policy: ACCEPT
> -p 0x600 -j CONTINUE
>
> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
> ---
> v2: address comments by Pablo.
>
> The printing path doesn't require special handling. There are 3 cases:
> * a target extension (unsupported yet)
> * an user-defined chain (in this case, cs->jumpto contains the chain name)
> * nothing (in this case, cs->jumpto contains "", and we should print CONTINUE)
OK, applied, thanks.
prev parent reply other threads:[~2015-01-06 21:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 14:28 [ebtables-compat PATCH v2] ebtables-compat: fix segfault in rules w/o target Arturo Borrero Gonzalez
2015-01-06 21:18 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106211850.GA5942@salvia \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=giuseppelng@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).