From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Steven Barth <cyrus@openwrt.org>
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH 5/5] build: add --without-libgmp switch to disable use of shared libgmp
Date: Tue, 6 Jan 2015 22:25:21 +0100 [thread overview]
Message-ID: <20150106212521.GA5981@salvia> (raw)
In-Reply-To: <1419787065-26146-6-git-send-email-cyrus@openwrt.org>
On Sun, Dec 28, 2014 at 06:17:45PM +0100, Steven Barth wrote:
> This disables linking the >400 KB big libgmp and replace it with
> the builtin mini-gmp which only increases size by ~30KB.
This mini-gmp is useful for embedded environments.
Could you please merge patch 4/5 and 5/5?
For the option name, I'd suggest --with-mini-gmp.
Could you also update the INSTALL file to slightly describe this new
compile-time option?
Thanks.
prev parent reply other threads:[~2015-01-06 21:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 17:17 [nft PATCH 0/5] support for mini-gmp / embedded friendliness Steven Barth
2014-12-28 17:17 ` [PATCH 1/5] parser: rename VERSION token to HDRVERSION Steven Barth
2014-12-28 17:17 ` [PATCH 2/5] datatype: use mpz_set_str instead of gmp_sscanf Steven Barth
2014-12-28 17:17 ` [PATCH 3/5] erec: use stdio vasprintf instead of gmp_vasprintf Steven Barth
2014-12-28 17:17 ` [PATCH 4/5] mini-gmp: add mini-gmp source and headers from gmplib 6.0 Steven Barth
2014-12-28 17:17 ` [PATCH 5/5] build: add --without-libgmp switch to disable use of shared libgmp Steven Barth
2015-01-06 21:25 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106212521.GA5981@salvia \
--to=pablo@netfilter.org \
--cc=cyrus@openwrt.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).