netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: pablo@netfilter.org
Subject: [nf-next PATCH] netfilter: nft_compat: translate ebtables verdicts
Date: Thu, 29 Jan 2015 17:45:59 +0100	[thread overview]
Message-ID: <20150129164559.23327.66398.stgit@nfdev.cica.es> (raw)

Translate ebtables verdict to the ones used by the nf_tables engine,
so we can properly use ebtables target extensions from nft_compat.

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
 net/netfilter/nft_compat.c |   67 ++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 61 insertions(+), 6 deletions(-)

diff --git a/net/netfilter/nft_compat.c b/net/netfilter/nft_compat.c
index 7f90d06..8ac7238 100644
--- a/net/netfilter/nft_compat.c
+++ b/net/netfilter/nft_compat.c
@@ -52,9 +52,8 @@ nft_compat_set_par(struct xt_action_param *par, void *xt, const void *xt_info)
 	par->hotdrop	= false;
 }
 
-static void nft_target_eval(const struct nft_expr *expr,
-			    struct nft_data data[NFT_REG_MAX + 1],
-			    const struct nft_pktinfo *pkt)
+static int nft_target_eval_call(const struct nft_expr *expr,
+				const struct nft_pktinfo *pkt)
 {
 	void *info = nft_expr_priv(expr);
 	struct xt_target *target = expr->ops->data;
@@ -68,14 +67,66 @@ static void nft_target_eval(const struct nft_expr *expr,
 	if (pkt->xt.hotdrop)
 		ret = NF_DROP;
 
-	switch(ret) {
+	return ret;
+}
+
+static void nft_target_eval_set_verdict(struct nft_data data[NFT_REG_MAX + 1],
+					int verdict)
+{
+	switch (verdict) {
 	case XT_CONTINUE:
 		data[NFT_REG_VERDICT].verdict = NFT_CONTINUE;
 		break;
 	default:
-		data[NFT_REG_VERDICT].verdict = ret;
+		data[NFT_REG_VERDICT].verdict = verdict;
 		break;
 	}
+}
+
+static void nft_target_eval(const struct nft_expr *expr,
+			    struct nft_data data[NFT_REG_MAX + 1],
+			    const struct nft_pktinfo *pkt)
+{
+	int verdict;
+
+	verdict = nft_target_eval_call(expr, pkt);
+	nft_target_eval_set_verdict(data, verdict);
+
+	return;
+}
+
+static void nft_compat_translate_ebt_verdict(int *verdict)
+{
+	switch (*verdict) {
+	case EBT_ACCEPT:
+		*verdict = NF_ACCEPT;
+		break;
+	case EBT_DROP:
+		*verdict = NF_DROP;
+		break;
+	case EBT_CONTINUE:
+		*verdict = XT_CONTINUE;
+		break;
+	case EBT_RETURN:
+		*verdict = NFT_RETURN;
+		break;
+	default:
+		break;
+	}
+
+	return;
+}
+
+static void nft_target_bridge_eval(const struct nft_expr *expr,
+				   struct nft_data data[NFT_REG_MAX + 1],
+				   const struct nft_pktinfo *pkt)
+{
+	int verdict;
+
+	verdict = nft_target_eval_call(expr, pkt);
+	nft_compat_translate_ebt_verdict(&verdict);
+	nft_target_eval_set_verdict(data, verdict);
+
 	return;
 }
 
@@ -696,13 +747,17 @@ nft_target_select_ops(const struct nft_ctx *ctx,
 
 	nft_target->ops.type = &nft_target_type;
 	nft_target->ops.size = NFT_EXPR_SIZE(XT_ALIGN(target->targetsize));
-	nft_target->ops.eval = nft_target_eval;
 	nft_target->ops.init = nft_target_init;
 	nft_target->ops.destroy = nft_target_destroy;
 	nft_target->ops.dump = nft_target_dump;
 	nft_target->ops.validate = nft_target_validate;
 	nft_target->ops.data = target;
 
+	if (family == NFPROTO_BRIDGE)
+		nft_target->ops.eval = nft_target_bridge_eval;
+	else
+		nft_target->ops.eval = nft_target_eval;
+
 	list_add(&nft_target->head, &nft_target_list);
 
 	return &nft_target->ops;


             reply	other threads:[~2015-01-29 16:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 16:45 Arturo Borrero Gonzalez [this message]
2015-01-29 17:17 ` [nf-next PATCH] netfilter: nft_compat: translate ebtables verdicts Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150129164559.23327.66398.stgit@nfdev.cica.es \
    --to=arturo.borrero.glez@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).