From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [ebtables-compat PATCH 2/2] ebtables-compat: add mark target extension
Date: Fri, 30 Jan 2015 19:51:55 +0100 [thread overview]
Message-ID: <20150130185155.GB23146@salvia> (raw)
In-Reply-To: <20150129164439.21224.8860.stgit@nfdev.cica.es>
On Thu, Jan 29, 2015 at 05:44:39PM +0100, Arturo Borrero Gonzalez wrote:
> +static void brmark_final_check(unsigned int flags)
> +{
> + if (!flags)
> + xtables_error(PARAMETER_PROBLEM,
> + "You must specify some option");
You can provide better error reporting by checking this flags:
if (!(flags & OPTION1 | OPTION2 | OPTION3))
xtables_error(..., "you have to specify at least one of these: --option1, --option2, --option3");
if (!(flags & OPTION4))
xtables_error(..., "--option4 is mandatory");
Please, revisit this.
next prev parent reply other threads:[~2015-01-30 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 16:44 [ebtables-compat PATCH 1/2] libxtables: search first for AF-specific extension Arturo Borrero Gonzalez
2015-01-29 16:44 ` [ebtables-compat PATCH 2/2] ebtables-compat: add mark target extension Arturo Borrero Gonzalez
2015-01-29 17:02 ` Pablo Neira Ayuso
2015-01-30 18:51 ` Pablo Neira Ayuso [this message]
2015-02-03 15:21 ` Arturo Borrero Gonzalez
2015-01-30 18:45 ` [ebtables-compat PATCH 1/2] libxtables: search first for AF-specific extension Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150130185155.GB23146@salvia \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).