From: Chris Vine <chris@cvine.freeserve.co.uk>
To: Florian Westphal <fw@strlen.de>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netfilter-devel@vger.kernel.org,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: xt_recent broken in kernel 3.19.0 + PATCH
Date: Thu, 12 Feb 2015 10:26:16 +0000 [thread overview]
Message-ID: <20150212102616.786da70c@bother.homenet> (raw)
In-Reply-To: <20150212083533.GC22887@breakpoint.cc>
On Thu, 12 Feb 2015 09:35:33 +0100
Florian Westphal <fw@strlen.de> wrote:
> Cong Wang <xiyou.wangcong@gmail.com> wrote:
> > (Cc'ing netdev and netfilter-devel lists)
>
> Thanks for forwarding.
>
> > > Chris Vine <chris@cvine.freeserve.co.uk> wrote:
> > >> iptables -D SSH_CHAIN -m conntrack --ctstate NEW \
> > >> -m recent --update --seconds $SSH_LOGIN_PERIOD --hitcount
> > >> $SSH_TRIES -j DROP
> > > --- linux-3.19.0/net/netfilter/xt_recent.c~ 2015-02-10
> > > 09:18:44.657376355 +0000 +++
> > > linux-3.19.0/net/netfilter/xt_recent.c 2015-02-11
> > > 17:58:33.311608835 +0000 @@ -378,7 +378,7 @@
> > > mutex_lock(&recent_mutex); t = recent_table_lookup(recent_net,
> > > info->name); if (t != NULL) {
> > > - if (info->hit_count > t->nstamps_max_mask) {
> > > + if (info->hit_count > t->nstamps_max_mask + 1) {
>
> Looks good. Chris, could you formally submit this patch to
> netfilter-devel@vger.kernel.org?
>
> Thanks!
Done.
Chris
next prev parent reply other threads:[~2015-02-12 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150211092834.65f8ae80@bother.homenet>
[not found] ` <20150211183121.6688aec8@bother.homenet>
2015-02-12 3:15 ` xt_recent broken in kernel 3.19.0 + PATCH Cong Wang
2015-02-12 8:35 ` Florian Westphal
2015-02-12 10:26 ` Chris Vine [this message]
2015-02-12 10:54 ` Chris Vine
2015-02-12 11:11 ` Chris Vine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150212102616.786da70c@bother.homenet \
--to=chris@cvine.freeserve.co.uk \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).