From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Bojan Prtvar <prtvar.b@gmail.com>
Cc: netdev@vger.kernel.org, tgraf@suug.ch,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
dan.carpenter@oracle.com
Subject: Re: [PATCH] net: Remove state argument from skb_find_text()
Date: Thu, 19 Feb 2015 01:05:59 +0100 [thread overview]
Message-ID: <20150219000559.GA28854@salvia> (raw)
In-Reply-To: <1424301408-3659-1-git-send-email-prtvar.b@gmail.com>
On Thu, Feb 19, 2015 at 12:16:48AM +0100, Bojan Prtvar wrote:
> Although it is clear that textsearch state is intentionally passed
> to skb_find_text() as uninitialized argument, it was never used by
> the callers. Therefore, we can simplify skb_find_text() by making it
> local variable.
This infrastructure was conceived to allow keeping the state between
chunk of data, I don't find a good reason to restrict this.
next prev parent reply other threads:[~2015-02-19 0:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 23:16 [PATCH] net: Remove state argument from skb_find_text() Bojan Prtvar
2015-02-19 0:05 ` Pablo Neira Ayuso [this message]
2015-02-20 22:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219000559.GA28854@salvia \
--to=pablo@netfilter.org \
--cc=dan.carpenter@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=prtvar.b@gmail.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).