From: David Miller <davem@davemloft.net>
To: johunt@akamai.com
Cc: pablo@netfilter.org, kaber@trash.net, tgraf@suug.ch,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
daniel@iogearbox.net
Subject: Re: [PATCH v2 1/2] rhashtable: require max_shift if grow_decision defined
Date: Tue, 24 Feb 2015 13:18:28 -0500 (EST) [thread overview]
Message-ID: <20150224.131828.1632037288300527014.davem@davemloft.net> (raw)
In-Reply-To: <1424794259-30241-2-git-send-email-johunt@akamai.com>
From: Josh Hunt <johunt@akamai.com>
Date: Tue, 24 Feb 2015 11:10:57 -0500
> If an rhashtable user defines a grow_decision fn they must also define a
> max_shift parameter.
>
> Signed-off-by: Josh Hunt <johunt@akamai.com>
I've already said today that I think this whole indirection stuff
with grow and shrink decisions should simply go away.
Everyone defines it to the generic rhashtable routine, therefore
that should just be made private to lib/rhashtable.c, called
directly, and the methods completely removed.
Given that, this change makes no sense.
When a limit is not specified, we should unconditionally grow rather
than refuse to grow. One should not be required to specify this at
all. If you have no idea what limit might be reasonable, you specify
nothing at all and just let available memory be the limiting factor.
next prev parent reply other threads:[~2015-02-24 18:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 16:10 [PATCH v2 0/2] nft hash resize fixes Josh Hunt
2015-02-24 16:10 ` [PATCH v2 1/2] rhashtable: require max_shift if grow_decision defined Josh Hunt
2015-02-24 16:40 ` Thomas Graf
2015-02-24 18:18 ` David Miller [this message]
2015-02-24 19:48 ` Daniel Borkmann
2015-02-24 21:31 ` David Miller
2015-02-24 22:49 ` Thomas Graf
2015-02-25 2:12 ` David Miller
2015-02-24 22:36 ` Josh Hunt
2015-02-24 16:10 ` [PATCH v2 2/2] nft_hash: define max_shift rhashtable parameter Josh Hunt
2015-02-24 16:42 ` Thomas Graf
2015-02-24 17:03 ` Josh Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224.131828.1632037288300527014.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=johunt@akamai.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).