netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, alexandre@r42.ch
Subject: Re: [PATCH nft v2] main: display errors through stderr
Date: Tue, 24 Feb 2015 19:18:02 +0000	[thread overview]
Message-ID: <20150224191801.GP3713@acer.localdomain> (raw)
In-Reply-To: <20150224190140.GA32754@salvia>

On 24.02, Pablo Neira Ayuso wrote:
> On Tue, Feb 24, 2015 at 06:35:05PM +0000, Patrick McHardy wrote:
> > On 24.02, Pablo Neira Ayuso wrote:
> > > Debugging still goes through stdout as Patrick requests.
> > > 
> > > Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1000
> > > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> > 
> > Thinking about it, EREC_INFORMATIONAL should also go to stdout I
> > suppose. But since we don't have any of those yet, we can change
> > it once we get the first message of this type.
> 
> I just remembered that bison is currently using stderr as output for
> debugging.
> 
> We're also telling people to save their rulesets via:
> 
>         nft list ruleset > file
> 
> If debugging still goes to stdout this will cause them problems. Not
> sure yet we should use stdout for debugging.

I still think it makes sense since you explicitly requested it, its not
an error, its very useful to be able to pipe it to less directly and
it preserves order between regular output and debugging without doing
anything else.

I guess people simply shouldn't save their rulesets when enabling
debugging. Its not like we're doing it by default.

      reply	other threads:[~2015-02-24 19:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 18:32 [PATCH nft v2] main: display errors through stderr Pablo Neira Ayuso
2015-02-24 18:35 ` Patrick McHardy
2015-02-24 19:01   ` Pablo Neira Ayuso
2015-02-24 19:18     ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150224191801.GP3713@acer.localdomain \
    --to=kaber@trash.net \
    --cc=alexandre@r42.ch \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).