From: Markus Teich <teichm@fs.tum.de>
To: netfilter-devel@vger.kernel.org
Subject: [libmnl] portability of getpagesize() in libmnl.h
Date: Tue, 24 Feb 2015 21:45:50 +0100 [thread overview]
Message-ID: <20150224204550.GZ3453@trolle> (raw)
Heyho,
the getpagesize() call in line
#define MNL_SOCKET_BUFFER_SIZE (getpagesize() < 8192L ? getpagesize() : 8192L)
of libmnl.h seems to be less portable than sysconf(_SC_PAGESIZE) as suggested by
the getpagesize man page. getpagesize() needs e.g. _BSD_SOURCE while sysconf()
does not.
Would you consider fixing this or should I write a patch?
(I'm not on the list, so please leave me a CC)
--Markus
next reply other threads:[~2015-02-24 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 20:45 Markus Teich [this message]
2015-02-26 13:08 ` [libmnl] portability of getpagesize() in libmnl.h Pablo Neira Ayuso
2015-02-26 13:38 ` [PATCH] header: use sysconf() instead of getpagesize() Markus Teich
2015-03-02 11:06 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224204550.GZ3453@trolle \
--to=teichm@fs.tum.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).