From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH 12/12] netfilter: bridge: move DNAT helper to br_netfilter Date: Tue, 10 Mar 2015 14:28:48 +0900 Message-ID: <20150310052845.GA12887@vergenet.net> References: <1425921275-9171-1-git-send-email-pablo@netfilter.org> <1425921275-9171-13-git-send-email-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org To: Pablo Neira Ayuso Return-path: Received: from mail-pa0-f52.google.com ([209.85.220.52]:41288 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683AbbCJF3B (ORCPT ); Tue, 10 Mar 2015 01:29:01 -0400 Received: by pablj1 with SMTP id lj1so72311117pab.8 for ; Mon, 09 Mar 2015 22:28:59 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1425921275-9171-13-git-send-email-pablo@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Hi Pablo, On Mon, Mar 09, 2015 at 06:14:35PM +0100, Pablo Neira Ayuso wrote: > Only one caller, there is no need to keep this in a header. > Move it to br_netfilter.c where this belongs to. > > Based on patch from Florian Westphal. net-next seems fail to compile due to this patch if CONFIG_BRIDGE_NETFILTER=m and CONFIG_BRIDGE=y which happened to be a configuration I had for some reason. net/bridge/br_device.c:39: undefined reference to `br_nf_prerouting_finish_bridge'