From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH next] netfilter: fix sparse warnings in reject handling
Date: Tue, 10 Mar 2015 15:00:21 +0100 [thread overview]
Message-ID: <20150310140021.GA15712@salvia> (raw)
In-Reply-To: <1425938655-9549-1-git-send-email-fw@strlen.de>
On Mon, Mar 09, 2015 at 11:04:15PM +0100, Florian Westphal wrote:
> make C=1 CF=-D__CHECK_ENDIAN__ shows following:
>
> net/bridge/netfilter/nft_reject_bridge.c:65:50: warning: incorrect type in argument 3 (different base types)
> net/bridge/netfilter/nft_reject_bridge.c:65:50: expected restricted __be16 [usertype] protocol [..]
> net/bridge/netfilter/nft_reject_bridge.c:102:37: warning: cast from restricted __be16
> net/bridge/netfilter/nft_reject_bridge.c:102:37: warning: incorrect type in argument 1 (different base types) [..]
> net/bridge/netfilter/nft_reject_bridge.c:121:50: warning: incorrect type in argument 3 (different base types) [..]
> net/bridge/netfilter/nft_reject_bridge.c:168:52: warning: incorrect type in argument 3 (different base types) [..]
> net/bridge/netfilter/nft_reject_bridge.c:233:52: warning: incorrect type in argument 3 (different base types) [..]
>
> Caused by two (harmless) errors:
> 1. htons() instead of ntohs()
> 2. __be16 for protocol in nf_reject_ipXhdr_put API, use u8 instead.
Applied, thanks. I'll pass to David a small pull request to focus on
resolving the existing issues first.
prev parent reply other threads:[~2015-03-10 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 22:04 [PATCH next] netfilter: fix sparse warnings in reject handling Florian Westphal
2015-03-10 14:00 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310140021.GA15712@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).