* Re: netfilter: Fix potential crash in nft_hash walker
[not found] <20150312235214.GA26546@gondor.apana.org.au>
@ 2015-03-13 10:50 ` Pablo Neira Ayuso
0 siblings, 0 replies; only message in thread
From: Pablo Neira Ayuso @ 2015-03-13 10:50 UTC (permalink / raw)
To: Herbert Xu; +Cc: David Miller, tgraf, netdev, Patrick McHardy, netfilter-devel
On Fri, Mar 13, 2015 at 10:52:14AM +1100, Herbert Xu wrote:
> When we get back an EAGAIN from rhashtable_walk_next we were
> treating it as a valid object which obviously doesn't work too
> well.
>
> Luckily this is hard to trigger so it seems nobody has run into
> it yet.
>
> This patch fixes it by redoing the next call when we get an EAGAIN.
I'll enqueue this for nf, thanks Herbert.
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> diff --git a/net/netfilter/nft_hash.c b/net/netfilter/nft_hash.c
> index c82df0a..37c15e6 100644
> --- a/net/netfilter/nft_hash.c
> +++ b/net/netfilter/nft_hash.c
> @@ -153,6 +153,8 @@ static void nft_hash_walk(const struct nft_ctx *ctx, const struct nft_set *set,
> iter->err = err;
> goto out;
> }
> +
> + continue;
> }
>
> if (iter->count < iter->skip)
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] only message in thread