From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Richard Weinberger <richard@nod.at>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, sameo@linux.intel.com,
aloisio.almeida@openbossa.org, lauro.venancio@openbossa.org,
davem@davemloft.net, kadlec@blackhole.kfki.hu, kaber@trash.net
Subject: Re: [PATCH 3/4] netfilter: Fix portid types
Date: Fri, 13 Mar 2015 14:01:55 +0100 [thread overview]
Message-ID: <20150313130155.GA1044@salvia> (raw)
In-Reply-To: <1426246276-15839-4-git-send-email-richard@nod.at>
On Fri, Mar 13, 2015 at 12:31:15PM +0100, Richard Weinberger wrote:
> The netlink portid is an unsigned integer, use this type
> also in netfilter.
This small cleanup I can still take it but...
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> net/netfilter/nfnetlink_log.c | 4 ++--
> net/netfilter/nfnetlink_queue_core.c | 7 ++++---
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
> index 11d85b3..7f00846 100644
> --- a/net/netfilter/nfnetlink_log.c
> +++ b/net/netfilter/nfnetlink_log.c
> @@ -62,7 +62,7 @@ struct nfulnl_instance {
> struct timer_list timer;
> struct net *net;
> struct user_namespace *peer_user_ns; /* User namespace of the peer process */
> - int peer_portid; /* PORTID of the peer process */
> + unsigned int peer_portid; /* PORTID of the peer process */
I think you have to use u32 for consistency. Other spots use the
datatype for the netlink portid.
I think same thing applies to other patches.
next prev parent reply other threads:[~2015-03-13 13:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 11:31 net: portid signedness and format string fixes Richard Weinberger
2015-03-13 11:31 ` [PATCH 1/4] netlink: Fix portid type in netlink_notify Richard Weinberger
2015-03-13 11:31 ` [PATCH 2/4] nfc: Fix portid type in urelease_work Richard Weinberger
2015-03-13 11:31 ` [PATCH 3/4] netfilter: Fix portid types Richard Weinberger
2015-03-13 13:01 ` Pablo Neira Ayuso [this message]
2015-03-13 13:19 ` Richard Weinberger
2015-03-13 11:31 ` [PATCH 4/4] netfilter: Fix format string of nfnetlink_queue proc file Richard Weinberger
2015-03-13 12:15 ` Pablo Neira Ayuso
2015-03-13 13:43 ` Richard Weinberger
2015-03-13 13:53 ` Pablo Neira Ayuso
2015-03-13 14:22 ` Richard Weinberger
2015-03-16 13:11 ` Pablo Neira Ayuso
2015-04-09 21:58 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150313130155.GA1044@salvia \
--to=pablo@netfilter.org \
--cc=aloisio.almeida@openbossa.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=richard@nod.at \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).