From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ken-ichirou MATSUZAWA <chamaken@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
The netfilter developer mailinglist
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH lnf-ct 0/2] add mark event filter
Date: Fri, 13 Mar 2015 14:13:28 +0100 [thread overview]
Message-ID: <20150313131328.GA1125@salvia> (raw)
In-Reply-To: <20150312221826.GA20782@gmail.com>
On Fri, Mar 13, 2015 at 07:18:26AM +0900, Ken-ichirou MATSUZAWA wrote:
> Hi,
>
> This patchset adds mark filter for event listener and its test.
> Would you review?
Looks fine.
It would be good if someone can send follow up patches to:
1) Replace hardcoded '127' values by constants.
2) Assert on too many address/mark/etc instead of silently ignoring.
The existing behaviour doesn't look good to me as the user will not
know that it has reach the limit. Unfortunately this function was not
designed at that time to return an error instead, so we cannot change
that :-(
next prev parent reply other threads:[~2015-03-13 13:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 22:18 [PATCH lnf-ct 0/2] add mark event filter Ken-ichirou MATSUZAWA
2015-03-12 22:21 ` [PATCH lnf-ct 1/2] conntrack: " Ken-ichirou MATSUZAWA
2015-03-12 22:24 ` [PATCH lnf-ct 2/2] qa: add test for " Ken-ichirou MATSUZAWA
2015-03-13 13:13 ` Pablo Neira Ayuso [this message]
2015-03-13 13:42 ` [PATCH lnf-ct 0/2] add " Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150313131328.GA1125@salvia \
--to=pablo@netfilter.org \
--cc=chamaken@gmail.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).