netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 2/3] parser: allow to reorder chain options
Date: Tue, 17 Mar 2015 13:29:32 +0100	[thread overview]
Message-ID: <20150317122932.GA16527@salvia> (raw)
In-Reply-To: <20150317121514.GM21401@acer.localdomain>

On Tue, Mar 17, 2015 at 12:15:14PM +0000, Patrick McHardy wrote:
> On 17.03, Pablo Neira Ayuso wrote:
> > This allows all possible combinations to work:
> > 
> >  nft add chain filter input { type filter hook input priority 0 \; }
> >  nft add chain filter input { priority 0 type filter hook input \; }
> 
> 
> I don't object to being able to change the order of type and hook,
> but priority logically belongs to the hook keyword, why change this?

When displaying the chain configuration, this shows in order.

But we're humans and I don't see a good reason why we should force
humans to order things in some specific way.

  reply	other threads:[~2015-03-17 12:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17 12:13 [PATCH nft 1/3] src: expose table flags Pablo Neira Ayuso
2015-03-17 12:13 ` [PATCH nft 2/3] parser: allow to reorder chain options Pablo Neira Ayuso
2015-03-17 12:15   ` Patrick McHardy
2015-03-17 12:29     ` Pablo Neira Ayuso [this message]
2015-03-17 12:42       ` Patrick McHardy
2015-03-17 12:13 ` [PATCH nft 3/3] src: allow to specify the default policy for base chains Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150317122932.GA16527@salvia \
    --to=pablo@netfilter.org \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).