netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [nft PATCH] rule: delete extra space in rule indentation
@ 2015-03-17 21:23 Arturo Borrero Gonzalez
  2015-03-18 10:10 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Arturo Borrero Gonzalez @ 2015-03-17 21:23 UTC (permalink / raw)
  To: netfilter-devel; +Cc: kaber, pablo

Annoying extra space in rule indentation.

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
 src/rule.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/rule.c b/src/rule.c
index 8d76fd0..9403c1e 100644
--- a/src/rule.c
+++ b/src/rule.c
@@ -237,11 +237,11 @@ void rule_print(const struct rule *rule)
 	const struct stmt *stmt;
 
 	list_for_each_entry(stmt, &rule->stmts, list) {
-		printf(" ");
 		stmt->ops->print(stmt);
+		printf(" ");
 	}
 	if (handle_output > 0)
-		printf(" # handle %" PRIu64, rule->handle.handle);
+		printf("# handle %" PRIu64, rule->handle.handle);
 }
 
 struct scope *scope_init(struct scope *scope, const struct scope *parent)


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [nft PATCH] rule: delete extra space in rule indentation
  2015-03-17 21:23 [nft PATCH] rule: delete extra space in rule indentation Arturo Borrero Gonzalez
@ 2015-03-18 10:10 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2015-03-18 10:10 UTC (permalink / raw)
  To: Arturo Borrero Gonzalez; +Cc: netfilter-devel, kaber

On Tue, Mar 17, 2015 at 10:23:27PM +0100, Arturo Borrero Gonzalez wrote:
> Annoying extra space in rule indentation.

What "extra space" are you refering to?

Could you include a small proof of it in the description? Thanks.

> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
> ---
>  src/rule.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/rule.c b/src/rule.c
> index 8d76fd0..9403c1e 100644
> --- a/src/rule.c
> +++ b/src/rule.c
> @@ -237,11 +237,11 @@ void rule_print(const struct rule *rule)
>  	const struct stmt *stmt;
>  
>  	list_for_each_entry(stmt, &rule->stmts, list) {
> -		printf(" ");
>  		stmt->ops->print(stmt);
> +		printf(" ");
>  	}
>  	if (handle_output > 0)
> -		printf(" # handle %" PRIu64, rule->handle.handle);
> +		printf("# handle %" PRIu64, rule->handle.handle);
>  }
>  
>  struct scope *scope_init(struct scope *scope, const struct scope *parent)
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-18 10:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-17 21:23 [nft PATCH] rule: delete extra space in rule indentation Arturo Borrero Gonzalez
2015-03-18 10:10 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).