From: Florian Westphal <fw@strlen.de>
To: Bernhard Thaler <bernhard.thaler@wvnet.at>
Cc: pablo@netfilter.org, kadlec@blackhole.kfki.hu,
netfilter-devel@vger.kernel.org, fw@strlen.de
Subject: Re: [PATCHv3 4/4] netfilter: bridge: rename br_parse_ip_options
Date: Wed, 25 Mar 2015 09:15:52 +0100 [thread overview]
Message-ID: <20150325081552.GF1685@breakpoint.cc> (raw)
In-Reply-To: <5512685D.2010804@wvnet.at>
Bernhard Thaler <bernhard.thaler@wvnet.at> wrote:
> br_parse_ip_options() does not parse any IP options, it validates IP
> packets as a whole and the function name is misleading.
>
> Rename br_parse_ip_options().
>
> Signed-off-by: Bernhard Thaler <bernhard.thaler@wvnet.at>
Looks good to me, but your MUA mangled this patch (line breaks, whitespace
damage) so the patch doesn't apply cleanly anymore.
Try mailing the patch to yourself and apply it, if that works
you're good to go.
next prev parent reply other threads:[~2015-03-25 8:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 7:48 [PATCHv3 4/4] netfilter: bridge: rename br_parse_ip_options Bernhard Thaler
2015-03-25 8:15 ` Florian Westphal [this message]
2015-03-29 21:26 ` [PATCHv4 " Bernhard Thaler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325081552.GF1685@breakpoint.cc \
--to=fw@strlen.de \
--cc=bernhard.thaler@wvnet.at \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).