From: Thomas Graf <tgraf@suug.ch>
To: Patrick McHardy <kaber@trash.net>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH 4/5] netfilter: nft_hash: restore struct nft_hash
Date: Wed, 25 Mar 2015 11:50:47 +0000 [thread overview]
Message-ID: <20150325115047.GA25732@casper.infradead.org> (raw)
In-Reply-To: <20150325113025.GA26242@acer.localdomain>
On 03/25/15 at 11:30am, Patrick McHardy wrote:
> I'm getting really annoyed that people keep sending patches touching
> this stuff without CCing either netfilter-devel or me personally.
>
> This is just causing unnecessary work. The code in nft_hash is going
> to get replaced anyways, so now I can rebase 30 patches for no gain
> at all.
>
> If you touch netfilter, CC the relevant lists and people please.
> Thanks!
Sorry about that Patrick. Not copying you on the nft_hash change
was a mistake. I apologize. I was only aware of your following
patchset which seemed compatible with my changes.
"[PATCH 0/2] netfilter: preparatory patches for set extensions"
If your larger patchset resolves the RCU lockdep splash in nft_hash
then we can also just revert 6b6f302ce ("rhashtable: Add
rhashtable_free_and_destroy()") or I can rebase it on top of your
series.
next prev parent reply other threads:[~2015-03-25 11:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 15:19 [PATCH 0/5] netfilter: nf_tables: assorted patches Patrick McHardy
2015-03-21 15:19 ` [PATCH 1/5] netfilter: nft_rbtree: fix locking Patrick McHardy
2015-03-21 15:19 ` [PATCH 2/5] netfilter: nf_tables: move struct net pointer to base chain Patrick McHardy
2015-03-25 11:13 ` Pablo Neira Ayuso
2015-03-21 15:19 ` [PATCH 3/5] netfilter: nf_tables: reject NFT_SET_ELEM_INTERVAL_END flag for non-interval sets Patrick McHardy
2015-03-21 15:19 ` [PATCH 4/5] netfilter: nft_hash: restore struct nft_hash Patrick McHardy
2015-03-25 11:19 ` Pablo Neira Ayuso
2015-03-25 11:22 ` Patrick McHardy
2015-03-25 11:28 ` Pablo Neira Ayuso
2015-03-25 11:30 ` Patrick McHardy
2015-03-25 11:50 ` Thomas Graf [this message]
2015-03-25 11:57 ` Patrick McHardy
2015-03-21 15:19 ` [PATCH 5/5] netfilter: nft_hash: indent rhashtable parameters Patrick McHardy
2015-03-22 19:17 ` [PATCH 0/5] netfilter: nf_tables: assorted patches Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325115047.GA25732@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).