netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Zhang Chunyu <zhangcy@cn.fujitsu.com>
Cc: netfilter-devel@vger.kernel.org, Gao feng <gaofeng@cn.fujitsu.com>
Subject: Re: [PATCH V3 1/2] Add revision field for xt_entry_target
Date: Thu, 26 Mar 2015 13:45:02 +0100	[thread overview]
Message-ID: <20150326124502.GA5372@salvia> (raw)
In-Reply-To: <1427362410-9255-2-git-send-email-zhangcy@cn.fujitsu.com>

On Thu, Mar 26, 2015 at 05:33:29AM -0400, Zhang Chunyu wrote:
> ---
>  arptables.c                              | 2 ++
>  extensions/arpt_CLASSIFY.c               | 1 +
>  extensions/arpt_mangle.c                 | 1 +
>  extensions/arpt_standard.c               | 1 +
>  include/arptables.h                      | 6 ++++++
>  include/linux/netfilter_arp/arp_tables.h | 3 ++-
>  6 files changed, 13 insertions(+), 1 deletion(-)
>
[...] 
> diff --git a/include/linux/netfilter_arp/arp_tables.h b/include/linux/netfilter_arp/arp_tables.h
> index 0acda66..0bf2457 100644
> --- a/include/linux/netfilter_arp/arp_tables.h
> +++ b/include/linux/netfilter_arp/arp_tables.h
> @@ -19,7 +19,7 @@
>  
>  #include <linux/netfilter_arp.h>
>  
> -#define ARPT_FUNCTION_MAXNAMELEN 30
> +#define ARPT_FUNCTION_MAXNAMELEN 29
>  #define ARPT_TABLE_MAXNAMELEN 32
>  
>  #define ARPT_DEV_ADDR_LEN_MAX 16
> @@ -69,6 +69,7 @@ struct arpt_entry_target
>  
>  			/* Used by userspace */
>  			char name[ARPT_FUNCTION_MAXNAMELEN];
> +			u_int8_t revision;
>  		} user;
>  		struct {
>  			u_int16_t target_size;

Could you also resubmit the kernel patch to adds this? Please, no need
to resend the full userspace series, just send the kernel patch as a
follow up.

  reply	other threads:[~2015-03-26 12:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26  9:33 [PATCH V3 0/2] add mark target Zhang Chunyu
2015-03-26  9:33 ` [PATCH V3 1/2] Add revision field for xt_entry_target Zhang Chunyu
2015-03-26 12:45   ` Pablo Neira Ayuso [this message]
2015-03-27  1:34     ` Zhang, Chunyu
2015-03-27 11:02       ` Pablo Neira Ayuso
2015-03-30  1:30         ` Zhang, Chunyu
2015-03-26  9:33 ` [PATCH V3 2/2] Add MARK target for arptables Zhang Chunyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150326124502.GA5372@salvia \
    --to=pablo@netfilter.org \
    --cc=gaofeng@cn.fujitsu.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=zhangcy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).