From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>,
Netfilter Development Mailing list
<netfilter-devel@vger.kernel.org>
Subject: Re: [nft PATCH 2/3] src: add xt compat support
Date: Fri, 27 Mar 2015 13:14:11 +0000 [thread overview]
Message-ID: <20150327131411.GA3001@acer.localdomain> (raw)
In-Reply-To: <20150327131354.GA11617@salvia>
On 27.03, Pablo Neira Ayuso wrote:
> On Fri, Mar 27, 2015 at 01:59:31PM +0100, Arturo Borrero Gonzalez wrote:
> > >> >> index 0000000..414f3d1
> > >> >> --- /dev/null
> > >> >> +++ b/include/xt.h
> > >> >> @@ -0,0 +1,100 @@
> > >> >> +#ifndef _NFT_XT_H_
> > >> >> +#define _NFT_XT_H_
> > >> >> +
> > >> >> +#include <net/if.h>
> > >> >> +
> > >> >> +/* Fake ebt_entry */
> > >> >> +struct ebt_entry {
> > >> >
> > >> > I think you can avoid this if you:
> > >> >
> > >> > #include <linux/netfilter_bridge/ebtables.h>
> > >>
> > >> Can't include <linux/netfilter_bridge/ebtables.h> because it includes
> > >> <linux/if.h> and clash with <net/if.h>
> > >
> > > There must be a clean way to fix this without embedding the ebt_entry
> > > structure.
> >
> > We seem to have the same problem in ebtables-compat:
> >
> > http://git.netfilter.org/iptables/tree/iptables/nft-bridge.h#n32
>
> Try to find a way to fix it there too ;-)
Can't we switch to the linux includes? We're Linux only anyways :)
next prev parent reply other threads:[~2015-03-27 13:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 19:15 [nft PATCH 1/3] src: expose delinearize/linearize structures and stmt_error() Arturo Borrero Gonzalez
2015-03-25 19:16 ` [nft PATCH 2/3] src: add xt compat support Arturo Borrero Gonzalez
2015-03-25 19:44 ` Pablo Neira Ayuso
2015-03-27 12:00 ` Arturo Borrero Gonzalez
2015-03-27 12:31 ` Pablo Neira Ayuso
2015-03-27 12:31 ` Patrick McHardy
2015-03-27 12:59 ` Arturo Borrero Gonzalez
2015-03-27 13:13 ` Pablo Neira Ayuso
2015-03-27 13:14 ` Patrick McHardy [this message]
2015-03-30 10:19 ` Arturo Borrero Gonzalez
2015-03-25 19:16 ` [nft PATCH 3/3] tests: regression: add xt compat tests Arturo Borrero Gonzalez
2015-03-25 19:23 ` [nft PATCH 1/3] src: expose delinearize/linearize structures and stmt_error() Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327131411.GA3001@acer.localdomain \
--to=kaber@trash.net \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).