netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Zhang Chunyu <zhangcy@cn.fujitsu.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH V4 0/3] Add mark target
Date: Thu, 2 Apr 2015 10:57:31 +0200	[thread overview]
Message-ID: <20150402085731.GA24296@salvia> (raw)
In-Reply-To: <1427682948-18699-1-git-send-email-zhangcy@cn.fujitsu.com>

On Sun, Mar 29, 2015 at 10:35:45PM -0400, Zhang Chunyu wrote:
> v1:
>   add mark target for arptables
> 
> v2:
>   add --and-mark
>   add --or-mark
>   add revision for common api
> 
> v3:
>   fold 2/4, 3/4 and 4/4 patch into one single patch
>   use C99 initialization
>   change some format
> 
> V4:
>   resubmit the kernel patch

net/netfilter/xt_mark.c is missing a small change, you have to add
MODULE_ALIAS("arpt_MARK").

And after that, I hitting here:

# arptables -I OUTPUT -j MARK --set-mark 1
arptables: Protocol wrong type for socket

With my arptables patches applied in first place, so I suspect the
right revision is not being set in what we send to the kernel from
userspace.

  parent reply	other threads:[~2015-04-02  8:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30  2:35 [PATCH V4 0/3] Add mark target Zhang Chunyu
2015-03-30  2:35 ` [PATCH V4 1/3] Add revision field for xt_entry_target Zhang Chunyu
2015-03-30  2:35 ` [PATCH V4 2/3] Add revision field for arptables userspace Zhang Chunyu
2015-03-30  2:35 ` [PATCH V4 3/3] Add MARK target for arptables Zhang Chunyu
2015-04-02  8:57 ` Pablo Neira Ayuso [this message]
2015-04-02 10:04   ` Re: [PATCH V4 0/3] Add mark target Zhang, Chunyu
2015-04-03  3:21     ` Zhang, Chunyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150402085731.GA24296@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=zhangcy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).