From: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: pablo@netfilter.org
Subject: [iptables PATCH] ebtables-compat: fix misplaced function attribute on ebt_print_error()
Date: Mon, 06 Apr 2015 16:05:28 +0200 [thread overview]
Message-ID: <20150406140528.30059.48340.stgit@nfdev2.cica.es> (raw)
From: Arturo Borrero Gonzalez <aborrero@nfdev2.cica.es>
xtables-eb.c:305:1: warning: empty declaration
} __attribute__((noreturn, format(printf,2,3)));
^
xtables-eb.c:311:2: warning: initialization makes '__attribute__((noreturn))' qualified function pointer from unqualified
.exit_err = ebt_print_error,
^
Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
iptables/xtables-eb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/iptables/xtables-eb.c b/iptables/xtables-eb.c
index ddef14a..c8b5d4f 100644
--- a/iptables/xtables-eb.c
+++ b/iptables/xtables-eb.c
@@ -292,7 +292,7 @@ static struct option ebt_original_options[] =
{ 0 }
};
-static void
+static void __attribute__((__noreturn__,format(printf,2,3)))
ebt_print_error(enum xtables_exittype status, const char *format, ...)
{
va_list l;
@@ -302,7 +302,7 @@ ebt_print_error(enum xtables_exittype status, const char *format, ...)
fprintf(stderr, ".\n");
va_end(l);
exit(-1);
-} __attribute__((noreturn, format(printf,2,3)));
+}
struct xtables_globals ebtables_globals = {
.option_offset = 0,
next reply other threads:[~2015-04-06 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 14:05 Arturo Borrero Gonzalez [this message]
2015-04-08 17:03 ` [iptables PATCH] ebtables-compat: fix misplaced function attribute on ebt_print_error() Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150406140528.30059.48340.stgit@nfdev2.cica.es \
--to=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).