From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: rick.jones2@hp.com, tom@herbertland.com, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, pablo@netfilter.org,
jiri@resnulli.us
Subject: Re: [PATCH 4/4] udp_tunnel: Pass UDP socket down through udp_tunnel{,6}_xmit_skb().
Date: Tue, 07 Apr 2015 22:13:28 -0400 (EDT) [thread overview]
Message-ID: <20150407.221328.1961195097281515709.davem@davemloft.net> (raw)
In-Reply-To: <1428449099.869458.250499317.11121567@webmail.messagingengine.com>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Wed, 08 Apr 2015 01:24:59 +0200
> There is one small problem which already was present before this patch
> because of my change b6a7719aedd7e5 ("ipv4: hash net ptr into
> fragmentation bucket selection"). It uses sock_net in iptunnel_xmit,
> which causes a NULL ptr panic. This patchset did make it more visible
> because of the explicit NULL passing but the bug was introduced by my
> patch.
>
> Just wanted to let you know if reports are coming in - I fix it up
> tomorrow. I will also explore the possibility to give each tunnel at
> least a raw socket, what Tom proposed.
>
> Rick Jones identified this, thanks!
Looking into this I also notice that ipip6_tunnel_xmit() passes
in skb->sk, that needs to be NULL too.
Want to take care of that along with your sock_net() fix?
Thanks!
next prev parent reply other threads:[~2015-04-08 2:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 2:19 [PATCH 4/4] udp_tunnel: Pass UDP socket down through udp_tunnel{,6}_xmit_skb() David Miller
2015-04-07 6:02 ` Tom Herbert
2015-04-07 15:45 ` Hannes Frederic Sowa
2015-04-07 18:56 ` Tom Herbert
2015-04-07 19:14 ` Hannes Frederic Sowa
2015-04-07 19:30 ` David Miller
2015-04-07 23:24 ` Hannes Frederic Sowa
2015-04-08 2:13 ` David Miller [this message]
2015-04-08 15:03 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407.221328.1961195097281515709.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=rick.jones2@hp.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).