From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
jiri@resnulli.us
Subject: Re: [PATCH 3/4] netfilter: Pass socket pointer down through okfn().
Date: Tue, 7 Apr 2015 17:35:33 +0200 [thread overview]
Message-ID: <20150407153533.GA3979@salvia> (raw)
In-Reply-To: <1428417869.2928.1.camel@stressinduktion.org>
On Tue, Apr 07, 2015 at 04:44:29PM +0200, Hannes Frederic Sowa wrote:
> On So, 2015-04-05 at 22:19 -0400, David Miller wrote:
> > --- a/include/linux/netfilter.h
> > +++ b/include/linux/netfilter.h
> > @@ -54,7 +54,7 @@ struct nf_hook_state {
> > struct net_device *in;
> > struct net_device *out;
> > struct sock *sk;
> > - int (*okfn)(struct sk_buff *);
> > + int (*okfn)(struct sock *, struct sk_buff *);
> > };
>
> If we give okfn the signature int (*okfn)(struct nf_hook_state *); then
> we would not need to touch anything else to enhance this.
>
> What do you think?
I guess you mean something like:
int (*okfn)(struct sk_buff *, struct nf_hook_state *);
I agree that would save us from more changes on the okfn() signature.
I think it's OK if that change is introduced once we have some client
code that needs it, I mean in a follow up patch.
next prev parent reply other threads:[~2015-04-07 15:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 2:19 [PATCH 3/4] netfilter: Pass socket pointer down through okfn() David Miller
2015-04-07 14:44 ` Hannes Frederic Sowa
2015-04-07 15:35 ` Pablo Neira Ayuso [this message]
2015-04-07 16:01 ` David Miller
2015-04-07 18:56 ` Hannes Frederic Sowa
2015-04-07 19:18 ` David Miller
2015-04-07 15:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407153533.GA3979@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).