From: David Miller <davem@davemloft.net>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: Fix switch statement warnings with recent gcc.
Date: Wed, 08 Apr 2015 15:21:04 -0400 (EDT) [thread overview]
Message-ID: <20150408.152104.2035331217337764143.davem@davemloft.net> (raw)
In-Reply-To: <20150408164614.GA22526@salvia>
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Wed, 8 Apr 2015 18:46:14 +0200
> On Tue, Apr 07, 2015 at 11:05:42PM -0400, David Miller wrote:
>>
>> More recent GCC warns about two kinds of switch statement uses:
>>
>> 1) Switching on an enumeration, but not having an explicit case
>> statement for all members of the enumeration. To show the
>> compiler this is intentional, we simply add a default case
>> with nothing more than a break statement.
>>
>> 2) Switching on a boolean value. I think this warning is dumb
>> but nevertheless you get it wholesale with -Wswitch.
>>
>> This patch cures all such warnings in netfilter.
>>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Ok I tossed this into net-next, thanks for reviewing.
prev parent reply other threads:[~2015-04-08 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 3:05 [PATCH] netfilter: Fix switch statement warnings with recent gcc David Miller
2015-04-08 16:46 ` Pablo Neira Ayuso
2015-04-08 19:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408.152104.2035331217337764143.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).