From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: tom@herbertland.com, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, pablo@netfilter.org,
jiri@resnulli.us
Subject: Re: [PATCH 0/4] Prevent UDP tunnels from operating on garbage socket
Date: Wed, 08 Apr 2015 16:03:03 -0400 (EDT) [thread overview]
Message-ID: <20150408.160303.1536044900311728443.davem@davemloft.net> (raw)
In-Reply-To: <1428406053.3932555.250169221.75848497@webmail.messagingengine.com>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Tue, 07 Apr 2015 13:27:33 +0200
> Also, I saw one inconsistency with sk_bound_dev_if in netfilter which
> doesn't get solved by this patchset (it uses skb->sk->sk_bound_dev_if
> unconditionally).
I looked at this quickly, and it'll take a bit of (mechanical) work to
resolve. Basically you have to get the socket down to ip_route_me_harder()
and sometimes that code path is coming from that XT targets, which don't
take the nf_hook_state as an argument or anything like that (yet).
prev parent reply other threads:[~2015-04-08 20:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 2:18 [PATCH 0/4] Prevent UDP tunnels from operating on garbage socket David Miller
2015-04-06 13:59 ` Tom Herbert
2015-04-06 16:41 ` David Miller
2015-04-06 17:17 ` David Miller
[not found] ` <CALx6S34CvOZN3dZjXr6_1afCbUDu2718cCGPk2Sm1Nkq8wCGKA@mail.gmail.com>
2015-04-06 19:38 ` David Miller
2015-04-07 2:43 ` Tom Herbert
2015-04-07 3:51 ` David Miller
2015-04-07 4:45 ` Tom Herbert
2015-04-07 5:03 ` Eric Dumazet
2015-04-07 8:20 ` Wilco Baan Hofman
2015-04-07 5:29 ` David Miller
2015-04-07 11:27 ` Hannes Frederic Sowa
2015-04-08 20:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408.160303.1536044900311728443.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).