* [iptables PATCH] ebtables-compat: fix misplaced function attribute on ebt_print_error()
@ 2015-04-06 14:05 Arturo Borrero Gonzalez
2015-04-08 17:03 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Arturo Borrero Gonzalez @ 2015-04-06 14:05 UTC (permalink / raw)
To: netfilter-devel; +Cc: pablo
From: Arturo Borrero Gonzalez <aborrero@nfdev2.cica.es>
xtables-eb.c:305:1: warning: empty declaration
} __attribute__((noreturn, format(printf,2,3)));
^
xtables-eb.c:311:2: warning: initialization makes '__attribute__((noreturn))' qualified function pointer from unqualified
.exit_err = ebt_print_error,
^
Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
iptables/xtables-eb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/iptables/xtables-eb.c b/iptables/xtables-eb.c
index ddef14a..c8b5d4f 100644
--- a/iptables/xtables-eb.c
+++ b/iptables/xtables-eb.c
@@ -292,7 +292,7 @@ static struct option ebt_original_options[] =
{ 0 }
};
-static void
+static void __attribute__((__noreturn__,format(printf,2,3)))
ebt_print_error(enum xtables_exittype status, const char *format, ...)
{
va_list l;
@@ -302,7 +302,7 @@ ebt_print_error(enum xtables_exittype status, const char *format, ...)
fprintf(stderr, ".\n");
va_end(l);
exit(-1);
-} __attribute__((noreturn, format(printf,2,3)));
+}
struct xtables_globals ebtables_globals = {
.option_offset = 0,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [iptables PATCH] ebtables-compat: fix misplaced function attribute on ebt_print_error()
2015-04-06 14:05 [iptables PATCH] ebtables-compat: fix misplaced function attribute on ebt_print_error() Arturo Borrero Gonzalez
@ 2015-04-08 17:03 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2015-04-08 17:03 UTC (permalink / raw)
To: Arturo Borrero Gonzalez; +Cc: netfilter-devel
On Mon, Apr 06, 2015 at 04:05:28PM +0200, Arturo Borrero Gonzalez wrote:
> From: Arturo Borrero Gonzalez <aborrero@nfdev2.cica.es>
>
> xtables-eb.c:305:1: warning: empty declaration
> } __attribute__((noreturn, format(printf,2,3)));
> ^
> xtables-eb.c:311:2: warning: initialization makes '__attribute__((noreturn))' qualified function pointer from unqualified
> .exit_err = ebt_print_error,
> ^
Applied, thanks Arturo.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-08 16:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-06 14:05 [iptables PATCH] ebtables-compat: fix misplaced function attribute on ebt_print_error() Arturo Borrero Gonzalez
2015-04-08 17:03 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).