netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net, pablo@netfilter.org
Subject: Re: [nft PATCH 1/4] include: cache a copy of kernel ebtables.h
Date: Wed, 8 Apr 2015 17:22:49 -0700	[thread overview]
Message-ID: <20150408172249.49bbc646@urahara> (raw)
In-Reply-To: <20150408174818.28553.96128.stgit@nfdev2.cica.es>

On Wed, 08 Apr 2015 19:48:18 +0200
Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com> wrote:

> From: Arturo Borrero Gonzalez <aborrero@nfdev2.cica.es>
> 
> Required for next patches.
> 
> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>

If you are going to import a kernel header, it should be the exact version
produced by doing: 
  $ make headers_install
in the kernel source directory
the result of that make is files in usr/include/linux

And your version differs:


$ diff -up usr/include/linux/netfilter_bridge/ebtables.h /tmp/ebtables.h 
--- usr/include/linux/netfilter_bridge/ebtables.h	2015-02-05 10:17:17.865621216 -0800
+++ /tmp/ebtables.h	2015-04-08 17:20:40.265458995 -0700
@@ -12,9 +12,7 @@
 
 #ifndef __LINUX_BRIDGE_EFF_H
 #define __LINUX_BRIDGE_EFF_H
-#include <linux/if.h>
 #include <linux/netfilter_bridge.h>
-#include <linux/if_ether.h>
 
 #define EBT_TABLE_MAXNAMELEN 32
 #define EBT_CHAIN_MAXNAMELEN EBT_TABLE_MAXNAMELEN

  parent reply	other threads:[~2015-04-09  0:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 17:48 [nft PATCH 1/4] include: cache a copy of kernel ebtables.h Arturo Borrero Gonzalez
2015-04-08 17:48 ` [nft PATCH 2/4] src: expose delinearize/linearize structures and stmt_error() Arturo Borrero Gonzalez
2015-04-08 17:48 ` [nft PATCH 3/4] src: add xt compat support Arturo Borrero Gonzalez
2015-04-09 12:58   ` Pablo Neira Ayuso
2015-04-09 15:47     ` Pablo Neira Ayuso
2015-04-08 17:48 ` [nft PATCH 4/4] tests: regression: add xt compat tests Arturo Borrero Gonzalez
2015-04-09 15:46   ` Pablo Neira Ayuso
2015-04-09  0:22 ` Stephen Hemminger [this message]
2015-04-09  8:18   ` [nft PATCH 1/4] include: cache a copy of kernel ebtables.h Arturo Borrero Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150408172249.49bbc646@urahara \
    --to=stephen@networkplumber.org \
    --cc=arturo.borrero.glez@gmail.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).