From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: Re: [PATCH] Add NFPROTO_ARP for mark Date: Thu, 9 Apr 2015 12:41:49 +0200 Message-ID: <20150409104149.GA3568@salvia> References: <1428374716-15108-1-git-send-email-zhangcy@cn.fujitsu.com> <1428374716-15108-2-git-send-email-zhangcy@cn.fujitsu.com> <20150408174911.GA4683@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "netfilter-devel@vger.kernel.org" To: "Zhang, Chunyu" Return-path: Received: from mail.us.es ([193.147.175.20]:42828 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932736AbbDIKhj (ORCPT ); Thu, 9 Apr 2015 06:37:39 -0400 Content-Disposition: inline In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Thu, Apr 09, 2015 at 03:54:33AM +0000, Zhang, Chunyu wrote: > >From: Pablo Neira Ayuso > >Date: 2015-04-09 > >To: Zhang, Chunyu/=E7=AB=A0 =E6=98=A5=E5=AE=87 > >Subject: Re: [PATCH] Add NFPROTO_ARP for mark [...] > >> @@ -41,13 +42,23 @@ mark_mt(const struct sk_buff *skb, struct xt_a= ction_param *par) > >> return ((skb->mark & info->mask) =3D=3D info->mark) ^ info->= invert; > >> } > >>=20 > >> -static struct xt_target mark_tg_reg __read_mostly =3D { > >> - .name =3D "MARK", > >> - .revision =3D 2, > >> - .family =3D NFPROTO_UNSPEC, > >> - .target =3D mark_tg, > >> - .targetsize =3D sizeof(struct xt_mark_tginfo2), > >> - .me =3D THIS_MODULE, > >> +static struct xt_target mark_tg_reg[] __read_mostly =3D { > >> + { > >> + .name =3D "MARK", > >> + .revision =3D 2, > >> + .family =3D NFPROTO_UNSPEC, > >> + .target =3D mark_tg, > >> + .targetsize =3D sizeof(struct xt_mark_tginfo2), > >> + .me =3D THIS_MODULE, > >> + }, > >> + { > >> + .name =3D "MARK", > >> + .revision =3D 2, > >> + .family =3D NFPROTO_ARP, > >> + .target =3D mark_tg, > >> + .targetsize =3D sizeof(struct xt_mark_tginfo2), > >> + .me =3D THIS_MODULE, > >> + } > >> }; > > > >You don't need this. > > > >The problem is here that your patch: > > > >http://patchwork.ozlabs.org/patch/455966/ > > > >is missing this chunk: > > > >diff --git a/libarptc/libarptc_incl.c b/libarptc/libarptc_incl.c > >index a034930..87404ce 100644 > >--- a/libarptc/libarptc_incl.c > >+++ b/libarptc/libarptc_incl.c > >@@ -872,7 +872,7 @@ map_target(const TC_HANDLE_T handle, > > /* memset to all 0 for your memcmp convenience. */ > > memset(t->u.user.name + strlen(t->u.user.name), > > 0, > >- FUNCTION_MAXNAMELEN - strlen(t->u.user.name)); > >+ FUNCTION_MAXNAMELEN - 1 - strlen(t->u.user.name)); > > return 1; > > } > > > >Otherwise, the revision number is zeroed. > > > >And you don't need: http://patchwork.ozlabs.org/patch/455965/. > > > >Please, rebase your userspace patches on top of current arptables gi= t > >and resubmit. Thanks. > > get it =E3=80=82will do=E3=80=82 > why arptables --set-mark can work , when add NFPROTO_ARP to xt_mark = ? I guess you're still using the userspace patches you sent. If you rebase on top of current arptables HEAD, that will not work. -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html