netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [iptables PATCH] libxtables: extensions find based also on family
Date: Thu, 9 Apr 2015 19:05:30 +0200	[thread overview]
Message-ID: <20150409170530.GA5725@salvia> (raw)
In-Reply-To: <20150408174219.25244.24487.stgit@nfdev2.cica.es>

On Wed, Apr 08, 2015 at 07:42:19PM +0200, Arturo Borrero Gonzalez wrote:
> When using libxtables with an external program (nft) which switches family
> contexts (using xtables_set_nfproto()), the extensions finding proccess
> needs to be smarter and also know about the family.
> 
> We want to avoid this situation:
> 
>  1) user first sets context to IPv6
>  2) xtables_find_target() finds & load ip6t_REJECT and uses it
>  3) context switch to IPv4
>  4) user then tries to use ipt_REJECT
>  5) xtables_find_target() will find ip6t_REJECT instead (same target name)
>  6) using ip6t_REJECT as ipt_REJECT can cause a lot of troubles

Applied with minor changes:

http://git.netfilter.org/iptables/commit/?id=06d14d702e481f29d5fdc33afab4347e6efb678d

Thanks.

      reply	other threads:[~2015-04-09 17:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 17:42 [iptables PATCH] libxtables: extensions find based also on family Arturo Borrero Gonzalez
2015-04-09 17:05 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150409170530.GA5725@salvia \
    --to=pablo@netfilter.org \
    --cc=arturo.borrero.glez@gmail.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).