From: Steven Rostedt <rostedt@goodmis.org>
To: Joe Perches <joe@perches.com>
Cc: Richard Weinberger <richard@nod.at>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, sameo@linux.intel.com,
aloisio.almeida@openbossa.org, lauro.venancio@openbossa.org,
davem@davemloft.net, kadlec@blackhole.kfki.hu, kaber@trash.net,
pablo@netfilter.org
Subject: Re: [PATCH 5/5 v2] netfilter: Fix format string of nfnetlink_log proc file
Date: Thu, 9 Apr 2015 18:43:42 -0400 [thread overview]
Message-ID: <20150409184342.4c3737a5@gandalf.local.home> (raw)
In-Reply-To: <1428619177.5413.15.camel@perches.com>
On Thu, 09 Apr 2015 15:39:37 -0700
Joe Perches <joe@perches.com> wrote:
> And Steven,
>
> commit e71456ae9871
> ("netfilter: Remove checks of seq_printf() return values")
> mistakenly converted this to use seq_has_overflowed()
>
> Ideally all seq_show functions would be converted from
>
> int foo_seq_show(...)
> {
> seq_printf(s, ...);
> return seq_has_overflowed(s);
> }
>
> to
>
> int foo_seq_show(...)
> {
> seq_printf(s, ...);
> return 0;
> }
>
> I made that mistake in a patch and corrected it later.
>
> Here's a suggested -next patch:
>
> Perhaps it shouldn't be submitted now as it may conflict
> with what Richard might submit if he propses an equivalent
> patch to above for -next.
>
> There is an appropriate use of return seq_has_overflowed in:
>
> net/netfilter/xt_hashlimit.c:825: return seq_has_overflowed(s);
>
> That's not a seq_show function, it's a helper for one.
I have other things to work on, so feel free to fix it up among
yourselves.
-- Steve
next prev parent reply other threads:[~2015-04-09 22:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 21:57 [PATCH 1/5 v2] netlink: Fix portid type in netlink_notify Richard Weinberger
2015-04-09 21:57 ` [PATCH 2/5 v2] nfc: Fix portid type in urelease_work Richard Weinberger
2015-04-09 21:57 ` [PATCH 3/5 v2] netfilter: Fix portid types Richard Weinberger
2015-04-09 21:57 ` [PATCH 4/5 v2] netfilter: Fix format string of nfnetlink_queue proc file Richard Weinberger
2015-04-09 21:57 ` [PATCH 5/5 v2] netfilter: Fix format string of nfnetlink_log " Richard Weinberger
2015-04-09 22:39 ` Joe Perches
2015-04-09 22:43 ` Steven Rostedt [this message]
2015-04-10 7:31 ` Richard Weinberger
2015-04-10 19:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150409184342.4c3737a5@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=aloisio.almeida@openbossa.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=richard@nod.at \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).