netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH RFC 0/2] nftables: fix time parsing
Date: Sat, 11 Apr 2015 18:52:50 +0200	[thread overview]
Message-ID: <20150411165250.GA8078@salvia> (raw)
In-Reply-To: <1428760830-6135-1-git-send-email-kaber@trash.net>

On Sat, Apr 11, 2015 at 03:00:28PM +0100, Patrick McHardy wrote:
> These patches attempt to fix time parsing to not require quotation marks
> around the time spec and loosen the checks so times can also be specified
> in smaller units.
> 
> Some testing indicates it works fine, however I'd put them into a branch
> for 4.1 since I mainly need this fixed for the set timeout support.

Thanks, this looks fine to me.

I still think that we need to consider flex start conditions or
something similar to make the scanner a bit smarter (stateful) to
avoid complexity on the parser.

I think that may also help to avoid the side issue related to this
patch:

http://patchwork.ozlabs.org/patch/443091/

Basically, the scanner takes this:

tcp sport vmap { 25:accept, 28:drop };ok
                 ^^^^^

as a tc handle.

  parent reply	other threads:[~2015-04-11 16:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-11 14:00 [PATCH RFC 0/2] nftables: fix time parsing Patrick McHardy
2015-04-11 14:00 ` [PATCH 1/2] datatype: fix parsing of time type Patrick McHardy
2015-04-11 14:00 ` [PATCH 2/2] datatype: less strict time parsing Patrick McHardy
2015-04-11 16:52 ` Pablo Neira Ayuso [this message]
2015-04-11 17:25   ` [PATCH RFC 0/2] nftables: fix " Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150411165250.GA8078@salvia \
    --to=pablo@netfilter.org \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).