From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Jan Engelhardt <jengelh@medozas.de>,
Jiri Pirko <jpirko@redhat.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: ipset: deinline ip_set_put_extensions()
Date: Thu, 14 May 2015 12:56:05 +0200 [thread overview]
Message-ID: <20150514105605.GA4852@salvia> (raw)
In-Reply-To: <1430922537-28428-1-git-send-email-dvlasenk@redhat.com>
On Wed, May 06, 2015 at 04:28:57PM +0200, Denys Vlasenko wrote:
> On x86 allyesconfig build:
> The function compiles to 489 bytes of machine code.
> It has 25 callsites.
>
> text data bss dec hex filename
> 82441375 22255384 20627456 125324215 7784bb7 vmlinux.before
> 82434909 22255384 20627456 125317749 7783275 vmlinux
Jozsef, I'm going to applied this patch to nf-next.
I think that things like ip_set_put_skbinfo() can be also deinlined
and move to the core as exported symbol as this run from the control
plane path (ie. netlink).
Thanks.
next prev parent reply other threads:[~2015-05-14 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 14:28 [PATCH] netfilter: ipset: deinline ip_set_put_extensions() Denys Vlasenko
2015-05-14 10:56 ` Pablo Neira Ayuso [this message]
2015-05-15 20:05 ` Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514105605.GA4852@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=dvlasenk@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jengelh@medozas.de \
--cc=jpirko@redhat.com \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).