From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH -nf] Revert "netfilter: bridge: query conntrack about skb dnat"
Date: Thu, 21 May 2015 13:26:03 +0200 [thread overview]
Message-ID: <20150521112603.GA5315@salvia> (raw)
In-Reply-To: <1432122145-20527-1-git-send-email-fw@strlen.de>
On Wed, May 20, 2015 at 01:42:25PM +0200, Florian Westphal wrote:
> This reverts commit c055d5b03bb4cb69d349d787c9787c0383abd8b2.
>
> There are two issues:
> 'dnat_took_place' made me think that this is related to
> -j DNAT/MASQUERADE.
>
> But thats only one part of the story. This is also relevant for SNAT
> when we undo snat translation in reverse/reply direction.
>
> Furthermore, I originally wanted to do this mainly to avoid
> storing ipv6 addresses once we make DNAT/REDIRECT work
> for ipv6 on bridges.
>
> However, I forgot about SNPT/DNPT which is stateless.
>
> So we can't escape storing address for ipv6 anyway. Might as
> well do it for ipv4 too.
Applied this revert to nf, thanks.
prev parent reply other threads:[~2015-05-21 11:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 11:42 [PATCH -nf] Revert "netfilter: bridge: query conntrack about skb dnat" Florian Westphal
2015-05-20 11:44 ` Florian Westphal
2015-05-21 11:26 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521112603.GA5315@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).